fix: show calendar in active window #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghsri
approved these changes
Oct 16, 2024
|
i think there is a bug here, the extension popup window isn't closing when going to calendar except the first time, at least in Arc, don't have the bandwidth to test in Chrome right now |
Razboy20
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we tried to have one global calendar page. One problem with that is that the tab could exist but might be in a window that can't be focused. When that happens, a user has no visual explanation of why the calendar refuses to open.
This PR makes the calendar page only show once per window, instead of once per browser.
Huly®: UTRP-309
This change is