Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python <3.13 and remove numpy pin #1169

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Conversation

edeno
Copy link
Collaborator

@edeno edeno commented Oct 23, 2024

Description

We previously restricted the maximum python version to be less than 3.10 due to the issue #408. This has now been fixed (see datajoint/datajoint-python#1007) and datajoint is tested up to python 3.12. Therefore, I propose we allow up to 3.12 as well.

We also restricted numpy due to issues with numba (#462). Numba is now compatible with all recent numpy versions (https://numba.readthedocs.io/en/stable/user/installing.html#version-support-information) although numpy 2.0 only has binary compatibility.

This PR will enable users to use more up to date packages with spyglass (see #831 for example).

Changes:

  • allow python versions up to 3.12
  • add testing for python versions 3.9-3.12.
  • remove importlib_metadata pin as twine 5.1.1 fixes that issue
  • remove pin on numpy version < 1.24

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno changed the title Increase allowed python version to <3.13 Increase allowed python version to <3.13 and remove numpy pin Oct 23, 2024
@edeno edeno requested a review from CBroz1 October 23, 2024 16:59
@edeno edeno changed the title Increase allowed python version to <3.13 and remove numpy pin Allow python <3.13 and remove numpy pin Oct 23, 2024
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for matrixing out python version I'm the tests. That will be good to have going forward

@CBroz1 CBroz1 merged commit e57638e into master Oct 23, 2024
16 checks passed
@CBroz1 CBroz1 deleted the increase-python-version branch October 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants