Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IntervalList orphans in nightly job only #1195

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 26, 2024

Description

Fixes #1194 (solution 2)

  • remove IntervalList cleanup from Mixin.delete()
  • Add IntervalList.cleanup() to documentation for nightly cron job

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review November 26, 2024 17:34
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note, but this looks good. Have you already edited the corresponding chron job script? I would want to make sure that's updated in tandem with this merge

docs/src/ForDevelopers/Management.md Outdated Show resolved Hide resolved
@edeno
Copy link
Collaborator

edeno commented Nov 27, 2024

Based on lab meeting discussion, should we move this to a weekly job?

@CBroz1
Copy link
Member

CBroz1 commented Nov 27, 2024

Based on lab meeting discussion, should we move this to a weekly job?

I think so. We could rename all nightly_cleanup to just cleanup, and set up a separate cron job for IntervalList.cleanup()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArtifactDetection creates orphan IntervalLists
3 participants