Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Heltec BMS (= YYBMS YanYang) #508

Closed
ramack opened this issue Apr 4, 2023 · 4 comments · Fixed by #658
Closed

Add Support for Heltec BMS (= YYBMS YanYang) #508

ramack opened this issue Apr 4, 2023 · 4 comments · Fixed by #658

Comments

@ramack
Copy link
Contributor

ramack commented Apr 4, 2023

Is your feature request related to a problem? Please describe.
I read on https://github.com/Louisvdw/dbus-serialbattery/wiki/BMS-types-supported that "JKBMS / Heltec BMS" are supported, so I tried to connect my Heltec Smart BMS 9-25S 100A RS485 but it is not detected by the dbus-serialbattery driver.

Describe the solution you'd like
According the docs I have (and what I spied on the RS485 with the scope) the BMS seems to talk Modbus RTU and is different from the JKBMS. So I propose to add support for this Heltec device. I don't know about other Heltec BMSs and if there is a variant that is compatible to JKBMS, but we might also want to update the docs accordingly.

@ramack
Copy link
Contributor Author

ramack commented Apr 15, 2023

I am working on this. @Louisvdw @mr-manuel should I base that work directly on the JKBMS-BLE branch?

@ramack ramack changed the title Add Support for Heltec BMS Add Support for Heltec BMS (= YYBMS YanYang) Apr 15, 2023
@mr-manuel
Copy link
Collaborator

If you are not adding a BLE driver than you can merge with the master branch. The only thing is that there are a lot of changes outstanding, see #468.
If you are adding only a new python file and the corresponding additions to include the file it should not be hard to merge.

@ramack
Copy link
Contributor Author

ramack commented Apr 16, 2023

OK thanks. The config.ini seems to be a very interesting change there... maybe the timeline to merge that into master us the main question right now

@mr-manuel
Copy link
Collaborator

Unfortunately @Louisvdw has not much time right now, but he will do so after 2nd May. If you want to keep it simple merge with the jkbms_ble branch, than I can review your PR and merge it directly.

Repository owner locked and limited conversation to collaborators Apr 25, 2023
@mr-manuel mr-manuel converted this issue into discussion #575 Apr 25, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants