Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using JKBMS name the is advertised in place of SerialBattery(JKBMS_BLE). #717

Closed
githubfrance opened this issue Jun 16, 2023 · 7 comments
Closed
Labels
enhancement New feature or request

Comments

@githubfrance
Copy link

Is your feature request related to a problem? Please describe.

Hi
With the JKBMS app we can change the name of the BMS
This name is advertised as you can see with bluetoothctl scan on
(my BMS's)
Device C8:47:8C:EC:F8:F9 JKBMS-Display
Device C8:47:8C:ED:06:11 JKBMS-Heating

But you are not using this name, you replace it with SerialBattery(JKBMS_BLE).

Describe the solution you'd like

I would like to have the advertised name used in Device/Name on Venus OS

Describe alternatives you've considered

An alternative coud be using the name in config.ini

BLUETOOTH_BMS = JKBMS-Heating C8:47:8C:ED:06:11, JKBMS-Display C8:47:8C:EC:F8:F9

Additional context

No response

@githubfrance githubfrance added the enhancement New feature or request label Jun 16, 2023
@mr-manuel
Copy link
Collaborator

Can you send a screenshot of the JKBMS where you entered the name?

Please post a screenshot of all values on the Device in the remote console/GUI -> SerialBattery -> Device.

@mr-manuel
Copy link
Collaborator

BTW, the name can already be set in the config.ini or by changing it in the remote console/GUI -> SerialBattery -> Device -> Name

@githubfrance
Copy link
Author

regarding config.ini how can I add the name for each mac address ?

@mr-manuel
Copy link
Collaborator

It's still in the alpha test phase, so there is no documentation yet except the config default file:

; Enter custom battery names here or change it over the GUI
; Example:
; /dev/ttyUSB0:My first battery
; /dev/ttyUSB0:My first battery,/dev/ttyUSB1:My second battery
CUSTOM_BATTERY_NAMES =

Please enter the name via GUI and the entry will be added automatically to the config file. I don't know how it behaves for the Bluetooth connected devices, but it's planned to link the name to the unique identifier, so that if the port changes the name get not lost. See #100 (comment).

@ogurevich

This comment was marked as off-topic.

@mr-manuel

This comment was marked as off-topic.

@ogurevich

This comment was marked as off-topic.

@mr-manuel mr-manuel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants