Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

After updating the latest ComfyUI, an error occurred. #238

Open
dream20201212 opened this issue Nov 5, 2023 · 8 comments
Open

After updating the latest ComfyUI, an error occurred. #238

dream20201212 opened this issue Nov 5, 2023 · 8 comments

Comments

@dream20201212
Copy link

Traceback (most recent call last):
File "/home/ComfyUI-master/nodes.py", line 1735, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/home/ComfyUI-master/custom_nodes/efficiency-nodes-comfyui/init.py", line 1, in
from .efficiency_nodes import NODE_CLASS_MAPPINGS
File "/home/ComfyUI-master/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 46, in
from .py import smZ_cfg_denoiser
File "/home/ComfyUI-master/custom_nodes/efficiency-nodes-comfyui/py/smZ_cfg_denoiser.py", line 7, in
from comfy.samplers import KSampler, CompVisVDenoiser, KSamplerX0Inpaint
ImportError: cannot import name 'CompVisVDenoiser' from 'comfy.samplers' (/home/ComfyUI-master/comfy/samplers.py)

@JAssertz
Copy link

JAssertz commented Nov 6, 2023

This is a result of the comfyUI change made a few days ago removing the "CompVisVDenoiser" you can view the changes in the commit here

comfyanonymous/ComfyUI@1777b54

@h3clikejava
Copy link

How to solve it?

@JAssertz
Copy link

JAssertz commented Nov 8, 2023

Currently toxicwind has a fork open that should allow it to work the other option is to re-add the missing section of code to the updated file.

@NeoAnthropocene
Copy link

Currently toxicwind has a fork open that should allow it to work the other option is to re-add the missing section of code to the updated file.

If it won't be a trouble for you, would you mind to write how we can do that, please?

@gik0geck0
Copy link

Switching forks in git:

cd ComfyUI/custom_nodes/efficiency-nodes-comfyui`
git remote add toxicwind https://github.com/toxicwind/efficiency-nodes-comfyui-updates.git
git fetch toxicwind
git checkout toxicwind/main

note: this is a detached head; if you wanted to resolve, git checkout -b some_interesting_named_branch -- I just leave it, since this is just temporary

Later, presumably when "this" efficiency-nodes does an update:

git fetch origin
git checkout main
git pull
git remote remove toxicwind

For more info: https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes and https://stackoverflow.com/questions/10228760/how-do-i-fix-a-git-detached-head

@gik0geck0
Copy link

gik0geck0 commented Nov 14, 2023

That fork gives me the following error, which has been fixed this fork. Use toxicwind's repo at your own risk; still hoping this issue gets some attention.
5db11dc#commitcomment-131987497

@gik0geck0
Copy link

This commit brings the removed code back over. Works for me, and prods' branch also fixes the above issue as well.
prods@05792e3

@andreszs
Copy link

andreszs commented Dec 3, 2023

This commit brings the removed code back over. Works for me, and prods' branch also fixes the above issue as well. prods@05792e3

I can confirm that repo fixes the CompVisVDenoiser error from original extension.

However I had to fix all my efficient node values because with this version, all values were displaced from their original input boxes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants