Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DbContext naming #11

Open
Foxtrek64 opened this issue Oct 15, 2019 · 0 comments
Open

Refactor DbContext naming #11

Foxtrek64 opened this issue Oct 15, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Foxtrek64
Copy link
Member

Across multiple files, the following naming scheme is used:

_context = DatabaseContext
Context = CommandContext

For instance,

guild.CommandPrefix = newPrefix;
await _context.SaveChangesAsync();
// await ReplyAsync($"Guild prefix updated: {oldPrefix} -> {guild.CommandPrefix}");
await Context.AddConfirmation();

This can lead to confusion and is generally pretty terrible naming overall.

This issue will be used to track the places this change needs to take place.

@Foxtrek64 Foxtrek64 added the enhancement New feature or request label Oct 15, 2019
@Foxtrek64 Foxtrek64 self-assigned this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant