Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back-fill, then forward-fill, NaNs in external regressors #1163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Back-fill, then forward-fill, NaNs in external regressors #1163

wants to merge 1 commit into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 7, 2025

Closes #1152.

Changes proposed in this pull request:

  • Warn if the external regressors have NaNs.
  • Back-fill (and forward-fill) cells with NaNs in the external regressors DataFrame.

@tsalo tsalo added the bug issues describing a bug or error found in the project label Jan 7, 2025
@tsalo tsalo requested a review from handwerkerd January 7, 2025 15:20
@tsalo tsalo changed the title Back-fill NaNs in external regressors Back-fill, then forward-fill, NaNs in external regressors Jan 7, 2025
@tsalo
Copy link
Member Author

tsalo commented Jan 7, 2025

Coverage didn't upload. Maybe they're disabled tokenless uploads?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handwerkerd handwerkerd Awaiting requested review from handwerkerd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External regressors with NaNs will crash decision tree
1 participant
@tsalo