Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pain Points of Tedana Meta-Issue #383

Closed
1 task
jbteves opened this issue Aug 16, 2019 · 15 comments
Closed
1 task

Pain Points of Tedana Meta-Issue #383

jbteves opened this issue Aug 16, 2019 · 15 comments
Labels
community issues related to building a healthy community

Comments

@jbteves
Copy link
Collaborator

jbteves commented Aug 16, 2019

Summary

We'll list common points of frustration or confusion here ahead of our hackathon

Running List

  • How to run
@jbteves jbteves added the community issues related to building a healthy community label Aug 16, 2019
@emdupre
Copy link
Member

emdupre commented Aug 16, 2019

  • How to run from the fMRIPrep working directory
  • How to run from AFNI proc
  • How to incorporate fieldmap corrections appropriately
  • Memory issues in running tedana
  • Changing the default PCA denoising ?

@smoia
Copy link
Collaborator

smoia commented Aug 16, 2019

  • Debug PCA denoising
  • Have a look at the elbow code for its PCA application
  • Get a general background of the ME maths related to the code

@dowdlelt
Copy link
Collaborator

  • using tedana after/with other software (SPM comes to mind)
  • degrees of freedom after tedana
  • using tedana regressors seperately

@jbteves
Copy link
Collaborator Author

jbteves commented Aug 16, 2019

@handwerkerd anything missing?

@handwerkerd
Copy link
Member

  • How to figure out if denoising ran correctly (i.e. easy summary stats)
  • How to figure out what can be run better, if the summary stats show an issue
  • How to decide which options to use
  • How to denoise across multiple runs during one session, across sessions/subjects
  • What steps to do before vs after denoising (i.e motion & distortion corrections)
  • Integrating recorded respiratory and physiological information into multi-echo denoising

@dowdlelt
Copy link
Collaborator

As post-tedana steps are developled (#344) I imagine they will add an additional, but user-desired, level of complexity so

  • How to use knowledge (motion estimates, maps) for component refinement

@jbteves
Copy link
Collaborator Author

jbteves commented Sep 11, 2019

I'm actually going to break the mold and add a developer point of frustration:

  • Running and modifying tests

@dowdlelt
Copy link
Collaborator

dowdlelt commented Sep 25, 2019

An additional one related to figures,

  • check orientation of brain/acquisition when making multiplanar cuts - rotate to normal.

Sometimes with R-L acquisitions the brain is flipped on its side, coronal isn't coronal, etc - That just adds a bit of frustration (and possible confusion) when inspecting output. May be an easy fix...

@dowdlelt
Copy link
Collaborator

dowdlelt commented Sep 27, 2019

And thought of another thing: the errors that pop up during running (not due credit, we know about that...). maybe these are environment specific, but they always worry me...

  • runtimes errors that cause confusion and concern

some examples:

/home/stone-ext4/logan/.local/lib/python3.6/site-packages/sklearn/externals/joblib/__init__.py:15:
 DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. 
Please import this functionality directly from joblib, which can be installed with: pip install joblib. If 
this warning is raised when loading pickled models, you may need to re-serialize those models with 
scikit-learn 0.21+.


RuntimeWarning: divide by zero encountered in true_divide
  F_S0 = (alpha - SSE_S0) * (n_echos - 1) / (SSE_S0)

INFO:tedana.metrics.kundu_fit:Performing spatial clustering of components
INFO:tedana.selection.tedica:Performing ICA component selection with Kundu decision tree v2.5
/home/stone-ext4/logan/.local/lib/python3.6/site-packages/tedana/selection/tedica.py:244: RuntimeWarning: invalid value encountered in double_scalars
  np.min(comptable.loc[acc_prov, 'variance explained'])))

@jbteves
Copy link
Collaborator Author

jbteves commented Sep 27, 2019

@dowdlelt FYI we've discussed a little bit about duecredit specifically in the now-closed #196. @tsalo at some point added the note that it doesn't impact package functionality.

@dowdlelt
Copy link
Collaborator

yeah, duecredit doesn't bother me at all, because it has the note and such - it is the other warnings while the package is running that are a bit more confusing. If users see problems in output, have trouble running, etc - then it would be natural for them to assume that these problems could be coming from the issues they see during code execution.

@jbteves
Copy link
Collaborator Author

jbteves commented Sep 30, 2019

Ack, sorry, I misread the above. I agree that we should fix the other warnings.

@smoia
Copy link
Collaborator

smoia commented Oct 3, 2019

  • Add a check on volumes and TE input order

@jbteves jbteves changed the title Pain Points of Tedana Meta-Issue Developer Pain Points of Tedana Meta-Issue Nov 10, 2019
@jbteves jbteves changed the title Developer Pain Points of Tedana Meta-Issue Pain Points of Tedana Meta-Issue Nov 10, 2019
@tsalo
Copy link
Member

tsalo commented Nov 19, 2022

This has been untouched for three years now. Can we update our pain points (I assume at least some have been addressed) and break this up into separate issues?

@tsalo
Copy link
Member

tsalo commented Feb 21, 2024

I think we have either addressed or opened separate issues for each of the pain points brought up in this issue, so I'm going to close it.

@tsalo tsalo closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community issues related to building a healthy community
Projects
None yet
Development

No branches or pull requests

6 participants