Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Signalement] Clôture de signalement impossible #3382

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Dec 3, 2024

Ticket

#3381

Description

Champ cloture[type] était géré par le bouton de soumission, la désactivation à la soumission provoque une régression.

Changements apportés

  • Utilisation du champ de type hidden présent dans le formulaire en remplacement du bouton
  • Mise à jour wording

Pré-requis

Tests

  • En tant que responsable territoire, vérifier que la clôture fonctionne accompagné du message de confirmation
  • En tant que agent et admin partenaire, vérifier que la clôture fonctionne du partenaire accompagné du message de confirmation

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS :

  • SA : cloturer pour tous les partenaires -> OK
  • RT : cloturer pour mon partenaire -> OK
  • RT : cloturer pour tous quand mon partenaire est clos-> OK
  • RT : cloturer pour tous quand mon partenaire n'est pas clos -> KO, seul mon partenaire est clos
  • agent : cloturer pour mon partenaire -> OK

src/Form/ClotureType.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@numew numew merged commit 1c6a056 into main Dec 4, 2024
5 of 6 checks passed
@sfinx13 sfinx13 deleted the hotfix/3381-cloture-impossible branch December 4, 2024 12:08
sfinx13 added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants