Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(invitation_email): add new scheduler after seven days #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@gaspard-lonchampt gaspard-lonchampt force-pushed the feat/invitation_email_after_7_days branch from 1f0baca to e56ddab Compare December 2, 2024 17:04
@gaspard-lonchampt gaspard-lonchampt force-pushed the feat/invitation_email_after_7_days branch 2 times, most recently from 0bd6a12 to 9110671 Compare December 4, 2024 09:07
@gaspard-lonchampt gaspard-lonchampt force-pushed the feat/invitation_email_after_7_days branch from 9110671 to 0ce5844 Compare December 4, 2024 16:29
Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Contributor

@tristan-gueguen tristan-gueguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarque dans la query, mais à part ça ça me paraît good

first_employee_invitation_date, companies_to_exclude=None
):

return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 je me demande juste s'il ne faudrait pas s'assurer qu'on n'a pas déjà envoyé l'email de relance à cette personne ? Car vu qu'on regarde ceux qui ont reçu l'autre email il y a au moins 7 jours, il risque de recevoir le rappel tous les jours non ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants