Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating reminders first sent in a different tz will have incorrect repeat length #18

Open
MaddyUnderStars opened this issue Mar 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@MaddyUnderStars
Copy link
Owner

If a reminder is sent in one tz, and it's notification will be sent in a different tz ( eg daylight savings ), we calculate if this is a into or from DST transition and subtract/add an hour accordingly.

However, for repeating reminders, this code is never run again. And so repeating reminders have their length set an additional hour in either direction to account for that first tz change.

@MaddyUnderStars MaddyUnderStars added the bug Something isn't working label Mar 16, 2023
@MaddyUnderStars MaddyUnderStars changed the title Repeating reminders first sent in a different tz will have incorrect repeat lenght Repeating reminders first sent in a different tz will have incorrect repeat length Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant