Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AvailabilityZone broken by GenericShow refactoring. #1080

Merged

Conversation

martinpovolny
Copy link
Member

https://bugzilla.redhat.com/show_bug.cgi?id=1443529

The extra line is called from show_timeline and RBAC is already checked at the beginning of the method.

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

Checked commit martinpovolny@32671c9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@martinpovolny
Copy link
Member Author

Hakiri and CC are crazy ;-)

@mzazrivec : please, review

@mzazrivec mzazrivec self-assigned this Apr 19, 2017
@mzazrivec mzazrivec added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 19, 2017
@mzazrivec mzazrivec merged commit 3fcf319 into ManageIQ:master Apr 19, 2017
simaishi pushed a commit that referenced this pull request Apr 19, 2017
…e_fix

Fix AvailabilityZone broken by GenericShow refactoring.
(cherry picked from commit 3fcf319)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c8ec19c48c904c99d52b7e79a94509f34273baf4
Author: Milan Zázrivec <[email protected]>
Date:   Wed Apr 19 16:31:06 2017 +0200

    Merge pull request #1080 from martinpovolny/availability_zone_timeline_fix
    
    Fix AvailabilityZone broken by GenericShow refactoring.
    (cherry picked from commit 3fcf319434a0d15cae70e15d94ce764860f7ded4)

@martinpovolny martinpovolny deleted the availability_zone_timeline_fix branch November 28, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants