Add the ability to customize JDBC Driver/Datasource defaults if not using standard options #1092
Conversation
|
BTW: last commit here is the only commit relevant to this PR: 756280a since previous commit is required for this. |
|
@miq-bot add_label middleware, enhancement, angular dialogs |
|
you can rebase since the prerequisite was merged :) |
| @@ -32,6 +32,9 @@ function MwAddDatasourceService($http, $q) { | |||
| {id: 'MYSQL', label: 'MySql', name: 'MySqlDS', jndiName: 'java:jboss/datasources/MySqlDS', | |||
| driverName: 'mysql', driverModuleName: 'com.mysql', driverClass: 'com.mysql.jdbc.Driver', | |||
| connectionUrl: '://localhost:3306/db_name'}, | |||
| {id: 'OTHER', label: 'Other...', name: '', jndiName: '', | |||
There was a problem hiding this comment.
unlike the other driver names that are more vendor specific, "Other" should probably be translation ready and not hardcoded
|
Checked commit https://github.com/mtho11/manageiq-ui-classic/commit/e45db5c961cf1e92d07421d7b9375649c22ef639 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @martinpovolny |
|
given that no response was received regarding fine |
|
@martinpovolny - bump |
Add the capability to provide an "Other..." option to customize both JDBC Driver defaults and Add Datasource (they both use the same angular service data). If one is using something other than the standard driver defaults we have provided, then give the user blank fields to add their own settings without having to delete each fields defaults. This is really just a usability feature for non-standard drivers.
Here is a screenshot further illustrating the 'Other...' options blanking out the standard defaults provided: