fix topology max items feature

[zeari]

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1455892
Fixes the feature introduced in #95. Setting an item limit for topology didnt work since theres inconsistency with the naming of the limit.
items is the correct term so what this PR does is s/objects/items/g to fix the bug.

[zeari]

@himdel @martinpovolny Please review.

[miq-bot]

Checked commit zeari@5add6f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[zeari]

Thanks @martinpovolny !

[simon3z]

@zeari @martinpovolny should we handle the error notification (in the Toplogy page) about containers_max_items?

[himdel]

@simon3z Definitely :). When is that happening? But looks like the code just dies if data.data.settings is null, so if that can happen, the code should be handling it, yes.

[simon3z]

@simon3z Definitely :). When is that happening? But looks like the code just dies if data.data.settings is null, so if that can happen, the code should be handling it, yes.

@himdel I just navigate to the Toplogy page (fresh install, never configured a max item setting).

[himdel]

Aah, makes sense, thanks .. looks like a simple (data.data.settings || {}).containers_max_items would do the trick.

Or maybe move it to that if and do } else if (data.data.settings && data.data.settings.containers_max_items) {.

[simon3z]

Aah, makes sense, thanks .. looks like a simple (data.data.settings || {}).containers_max_items would do the trick.

Or maybe move it to that if and do } else if (data.data.settings && data.data.settings.containers_max_items) {.

@zeari @himdel can anyone handle this?

[zeari]

@zeari @himdel can anyone handle this?

looking into it.

[simaishi]

Fine backport details:

$ git log -1
commit a3ea4bbb71ca93c7f5866ddc1b914e5c4054dc96
Author: Martin Povolny <[email protected]>
Date:   Mon May 29 13:44:47 2017 +0200

    Merge pull request #1453 from zeari/topology_fix_max_items
    
    fix topology max items feature
    (cherry picked from commit a26ddfcf769c9fcde2978bc2b39841ecbf8c7790)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460382