Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDs to ansible credential form selects #1487

Merged

Conversation

mzazrivec
Copy link
Contributor

The selects used in ansible credential form should have valid IDs.

https://bugzilla.redhat.com/show_bug.cgi?id=1456734

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2017

Checked commit mzazrivec@5fc0bfa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@himdel
Copy link
Contributor

himdel commented Jun 6, 2017

Does not set data-id properly - because the pfSelect initialization happens before that id is properly interpolated, and because element.selectpicker('refresh') does not pick up that ID after (presumably a patternfly bug).

However, this does make it simple to find the select by id, and the button is always that select's direct parent's direct descendant. ($("#select_id").parent().children('button') or $("#select_id").siblings('button'))

👍

@himdel himdel merged commit 3ab2b70 into ManageIQ:master Jun 6, 2017
@himdel himdel added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 6, 2017
simaishi pushed a commit that referenced this pull request Jun 12, 2017
…_form_selects

Add IDs to ansible credential form selects
(cherry picked from commit 3ab2b70)

https://bugzilla.redhat.com/show_bug.cgi?id=1460802
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 9be349e90e030a17d351cdb7b0185a5f3bb9ed7c
Author: Martin Hradil <[email protected]>
Date:   Tue Jun 6 11:27:16 2017 +0000

    Merge pull request #1487 from mzazrivec/add_ids_to_ansible_credential_form_selects
    
    Add IDs to ansible credential form selects
    (cherry picked from commit 3ab2b707f704e41e7b790c8a9256f924a05f1234)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460802

@mzazrivec mzazrivec deleted the add_ids_to_ansible_credential_form_selects branch September 11, 2017 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants