Skip calling Rbac on a null or nil target_class #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug @miq-bot assign @h-kataria -cc @gmcculloug |
|
Checked commit syncrou@1e222c6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2017
Skip calling Rbac on a null or nil target_class (cherry picked from commit fb1cba5) https://bugzilla.redhat.com/show_bug.cgi?id=1481851
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
fetch_target_idswe were always runningRbacregardless if the parameter:target_classwas populated or not.In some cases, when the empty option was selected, a 'null' was getting sent over and forcing
Rbacas well.This fixes both cases.
https://bugzilla.redhat.com/show_bug.cgi?id=1479570