Playbook automate method changes #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
playbook_automate_method_changes
branch
from
1051660 to
2b09d53
Compare
|
@h-kataria Changes look good. I was able to add/update new playbook type method. |
|
@h-kataria From the sceenshot it looks like the "Escalate Privilege" option is missing. |
|
@gmcculloug, on one of the calls @tinaafitz @syncrou had suggested to only keep Verbosity option on that screen and remove TTL, Escalate Privileges options. |
h-kataria
force-pushed
the
playbook_automate_method_changes
branch
17 times, most recently
from
b2c5e2d to
c66c22b
Compare
|
@gmcculloug Escalate Privilege checkbox has been added to Playbook method editor. |
h-kataria
changed the title
|
@martinpovolny addressed your comments above |
h-kataria
force-pushed
the
playbook_automate_method_changes
branch
4 times, most recently
from
3ef1466 to
f9c8bda
Compare
Added angular form to be displayed when user selects to add/edit "playbook" type Automate method, all other types are still using old haml form https://www.pivotaltracker.com/story/show/149747321
And some other minor cleanup/changes
Moved couple of common methods to application controller. Removed some unrequired/leftover code https://www.pivotaltracker.com/story/show/149747321
Fixed minor bug found during testing with validation of input parameter name. https://www.pivotaltracker.com/story/show/149747321
Added 'playbookReusableCodeMixin' for playbook related common methods. https://www.pivotaltracker.com/story/show/149747321
Needed to add checks if @angular_form is set to handle screens differently for Playbook type method add/edit. https://www.pivotaltracker.com/story/show/149747321
- removed a leftover debugging statement from view - moved methods that should be private to private area https://www.pivotaltracker.com/n/projects/1613907/stories/149747321
- Made changes to store all API.get promises and resolve them all at once and set afterGet flag to load the form - Fixed a repositoryChanged method call https://www.pivotaltracker.com/story/show/149747321
Hoping to fix code climate warning for "Avoid using a variable and instead use chaining with the getter syntax." https://www.pivotaltracker.com/story/show/149747321
- Addressed more PR review comments - Fixed broken spec test https://www.pivotaltracker.com/story/show/149747321
h-kataria
force-pushed
the
playbook_automate_method_changes
branch
from
f9c8bda to
d24f423
Compare
|
Checked commits h-kataria/manageiq-ui-classic@a23f61d~...d24f423 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/application_controller.rb
app/helpers/view_formatting_helper.rb
app/views/layouts/angular/_ansible_form_options_angular.html.haml
app/views/miq_ae_class/_angular_inputs_form.html.haml
app/views/miq_ae_class/_class_instances.html.haml
|
|
@martinpovolny please re-review, spec test failures are unrelated to changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/149747321
core PR: ManageIQ/manageiq#15939