Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow required flag to be set/unset for all dialog field types #2313

Conversation

eclarizio
Copy link
Member

As an add-on to #2185 discovered in the 5.8 clone: https://bugzilla.redhat.com/show_bug.cgi?id=1496946

#2185 fixed the ability to set the required property for dynamic drop down fields, but for some reason the required property was never included in the dialog_get_form_vars_field method for drop downs (as well as checkboxes).

This PR refactors the line for checking the required parameter that gets passed in when you click the checkbox in the UI, and ensures that it saves.

Note that again, the new dialog editor does not have this problem.

Original related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1492150

/cc @gmcculloug
@miq-bot add_label euwe/yes, fine/yes, bug
@miq-bot assign @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2017

Checked commit eclarizio@cc4048e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@eclarizio
Copy link
Member Author

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Oct 9, 2017
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 9, 2017
@h-kataria h-kataria merged commit f40bb3b into ManageIQ:master Oct 9, 2017
simaishi pushed a commit that referenced this pull request Oct 9, 2017
…ialog_field_types

Allow required flag to be set/unset for all dialog field types
(cherry picked from commit f40bb3b)

https://bugzilla.redhat.com/show_bug.cgi?id=1496946
@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2017

Fine backport details:

$ git log -1
commit e33276cfa07898d792a5257e9d65d32cfd052bff
Author: Harpreet Kataria <[email protected]>
Date:   Mon Oct 9 12:18:33 2017 -0400

    Merge pull request #2313 from eclarizio/allow_required_flag_for_all_dialog_field_types
    
    Allow required flag to be set/unset for all dialog field types
    (cherry picked from commit f40bb3ba78cd2d5e048da06398b46123d37ced2b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496946

@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2017

Euwe backport details:

$ git log -1
commit 7a95d49b47b434cbd3d6e7d2b223ebdc53fe33e0
Author: Harpreet Kataria <[email protected]>
Date:   Mon Oct 9 12:18:33 2017 -0400

    Merge pull request #2313 from eclarizio/allow_required_flag_for_all_dialog_field_types
    
    Allow required flag to be set/unset for all dialog field types
    (cherry picked from commit f40bb3ba78cd2d5e048da06398b46123d37ced2b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants