Add button classes #2371
Merged
Add button classes #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZitaNemeckova
force-pushed
the
add_button_classes
branch
3 times, most recently
from
321bd65 to
a9789b3
Compare
|
@miq-bot add_label fine/no |
|
@miq-bot remove_label pending core |
|
This pull request is not mergeable. Please rebase and repush. |
himdel
reviewed
Oct 24, 2017
| @@ -13,6 +13,8 @@ def custom_toolbar_explorer | |||
| Mixins::CustomButtons::Result.new(:single) | |||
| elsif @lastaction == "show_list" | |||
| Mixins::CustomButtons::Result.new(:list) | |||
| elsif x_tree[:tree] == :rbac_tree | |||
| @lastaction == "show_list" ? Mixins::CustomButtons::Result.new(:list) : Mixins::CustomButtons::Result.new(:single) | |||
There was a problem hiding this comment.
this is just Mixins::CustomButtons::Result.new(:single)
(the show_list branch will never happen because it will match on line 14)
ZitaNemeckova
force-pushed
the
add_button_classes
branch
from
caafa36 to
891c23e
Compare
ZitaNemeckova
force-pushed
the
add_button_classes
branch
from
891c23e to
e942171
Compare
ZitaNemeckova
force-pushed
the
add_button_classes
branch
from
e942171 to
c924fff
Compare
|
@miq-bot add_label gaprindashvili/yes |
|
Checked commits ZitaNemeckova/manageiq-ui-classic@525fda8~...c924fff with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 config/routes.rb
|
|
@miq-bot remove_label wip |
|
@mzazrivec please have a look. Issues with dialog will be resolved in separate PR. Thanks :) |
|
@miq-bot add_label bug |
5 tasks
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
Add button classes (cherry picked from commit 0697177)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom buttons to Container Node, Group, Tenant and User.
Create custom button without dialog:
Automation -> Automate -> Customization -> Buttons -> create a custom button without a dialog
Created buttons should show at:
Compute -> Containers -> Container Nodes
Configuration (right upper corner) -> Access Control -> Users/Groups/Tenants
https://www.pivotaltracker.com/story/show/147778977
Backend PR: ManageIQ/manageiq#16181 MERGED
After:
@miq-bot add_label wip, enhancement, euwe/no, automation/automate, pending core
https://bugzilla.redhat.com/show_bug.cgi?id=1508770
Issue with button that has a dialog will be solved in separate PR #2593.