Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for VmdbDatabase to not be present #2402

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 14, 2017

This commit allows for the Ops screen to continue to work even if the VmdbDatabase record is not present. Right now, a VmdbDatabase record is required to be present so that this screen does not blow up, and so it is required during seeding. Seeding this table is expensive, so we want to delay it, but we can't unless the ops screen can handle that.

@Fryguy
Copy link
Member Author

Fryguy commented Oct 14, 2017

Once this PR is merged I will change the core to remove VmdbDatabase from seeding and find a different way to get it in (perhaps a one-time refresh on the queue on boot). cc @jrafanie @kbrock

@miq-bot
Copy link
Member

miq-bot commented Oct 14, 2017

Checked commit Fryguy@8c4a3aa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 2 offenses detected

app/controllers/ops_controller/db.rb

@martinpovolny martinpovolny merged commit dcb4496 into ManageIQ:master Oct 14, 2017
@chessbyte chessbyte added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 16, 2017
@Fryguy Fryguy deleted the lazy_vmdb_database branch October 16, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants