Fix container provider endpoint configuration #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeari Cannot apply the following label because they are not recognized: compute\containers |
|
@miq-bot add_label compute/containers |
|
Checked commit zeari@031eca4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@zeari alerts endpoint: (should work for you with endpoints from another cluster) Can you give some context on the fix (I think I know what this is handling but am not sure) |
|
This PR also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1503798 |
|
tested this, worked for me. (including alerts endpoint) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simon3z @moolitayer @yaacov Please try to break the edit\new provider page.
It seems to be working on my end. I didnt have an alerts endpoint to work with though.
@miq-bot add_label compute\containers, bug