Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ext targeted alerts in the monitoring screen #2579

Merged
merged 2 commits into from
Nov 5, 2017
Merged

Ext targeted alerts in the monitoring screen #2579

merged 2 commits into from
Nov 5, 2017

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Oct 31, 2017 •
edited
Loading

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1507990

  • Consider only categorised tags for filtering
  • Hide target icon for ems alerts

Before
screenshot from 2017-10-31 17-04-56

After
alerts2

TBD:

  1. the ext icon should be aligned to the bottom for ems alerts (like it is in node alerts)
  2. the link should be fixed for ems alerts (still leads to node)

@moolitayer
Copy link
Author

@miq-bot add_label gaprindashvili/yes

@moolitayer
Copy link
Author

@himdel could you please review?
This is currently doing what I need, but I'm sure the implementation could be improved. Specifically the transparent class i'm using to force the ems line to the bottom.

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

Checked commits moolitayer/manageiq-ui-classic@567defb~...6f07fb3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@moolitayer
Copy link
Author

@himdel @martinpovolny please take a look

@moolitayer moolitayer closed this Nov 2, 2017
@moolitayer moolitayer reopened this Nov 2, 2017
@moolitayer
Copy link
Author

Tests fail to start with:

$ bundle exec rake $TEST_SUITE
rake aborted!
Errno::EADDRNOTAVAIL: Cannot assign requested address - connect(2) for "localhost" port 39021
/home/travis/build/ManageIQ/manageiq-ui-classic/vendor/bundle/ruby/2.3.0/gems/jasmine-2.5.2/lib/jasmine/base.rb:25:in `initialize'
...

@martinpovolny
Copy link
Member

Restarted travis.

@moolitayer
Copy link
Author

@martinpovolny thanks, test pass now. Please take a look

@martinpovolny martinpovolny merged commit 4325ccd into ManageIQ:master Nov 5, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 5, 2017
simaishi pushed a commit that referenced this pull request Nov 7, 2017
@martinpovolny @simaishi
Merge pull request #2579 from moolitayer/ext_targeted_alerts
acb3135 
Ext targeted alerts in the monitoring screen
(cherry picked from commit 4325ccd)

https://bugzilla.redhat.com/show_bug.cgi?id=1510481
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2017

Gaprindashvili backport details:

$ git log -1
commit acb31351fb4849ac0b3f11542f782c24d993169f
Author: Martin Povolny <[email protected]>
Date:   Sun Nov 5 12:11:01 2017 +0100

    Merge pull request #2579 from moolitayer/ext_targeted_alerts
    
    Ext targeted alerts in the monitoring screen
    (cherry picked from commit 4325ccd56c7957da72fff9d8b7e78731a7383fbc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
gaprindashvili/backported monitor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moolitayer @miq-bot @martinpovolny @simaishi