Angular Form with REST API calls for Playbook Service Template type.

[h-kataria]

This is a work in Progress, changes in this PR load an Angular form that consumes REST API to populate/save data in form when user tries to add an 'Ansible Playbook' type Service Template or edit an existing 'Ansible Playbook' type Service Template.

https://www.pivotaltracker.com/story/show/138302747

cc @lgalis

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[h-kataria]

Need to grab changes from ManageIQ/manageiq#13820 to be able to see "Ansible Playbook" entry in the Catalog Item type drop down when adding a new Catalog Item.

[bzwei]

Is label Key Value Pairs appropriate? Variables and default values might be a better label.

[h-kataria]

@bzwei updated label on the Key/Value Pairs table.

[bzwei]

@h-kataria Please change label Inventory to Hosts.

[h-kataria]

@himdel @martinpovolny @gmcculloug ready for review.

[h-kataria]

@himdel @martinpovolny please review this is an Ansible PR

[martinpovolny]

@h-kataria: with my limited Angular skills I see that you use the API, which is very cool! 👍 We need more people writing the UI code this way.

But I have noticed that you use the $scope and that we should avoid, especially for new code.

[himdel]

@h-kataria Agreed, I think this looks good :)

(@martinpovolny, this is using controllerAs, the remaining $scope references will have to stay for a while, until we can get all the directives ready for controllerAs.)

I think there will be some code climate issues though, mostly that we should prefer if (x) { y(); } over if (x) y();.

Also, the list of provider types should probably come from the API at some point instead of being hardcoded here, but not sure if possible right now...

[h-kataria]

@himdel getting list of Cloud credential types is being worked on, i will be making more changes in a follow up PR once API PR gets merged.

[miq-bot]

Checked commits h-kataria/manageiq-ui-classic@3c5455c~...d39b62c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 18 offenses detected

app/controllers/catalog_controller.rb

• ❗ - Line 169, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• ❗ - Line 171, Col 11 - Style/MultilineOperationIndentation - Align the operands of a condition in an if statement spanning multiple lines.
• ❕ - Line 143, Col 121 - Metrics/LineLength - Line is too long. [133/120]

app/views/catalog/_st_angular_form.html.haml

• ⚠️ - Line 15 - Prefer to_s over string interpolation.
• ⚠️ - Line 29 - Prefer to_s over string interpolation.

app/views/layouts/angular/_ansible_form_options_angular.html.haml

• ⚠️ - Line 150 - Line is too long. [204/160]
• ⚠️ - Line 151 - The = symbol should have one space separating it from code
• ⚠️ - Line 153 - The = symbol should have one space separating it from code
• ⚠️ - Line 155 - Avoid defining class in attributes hash for static class names
• ⚠️ - Line 155 - Line is too long. [163/160]
• ⚠️ - Line 156 - Line is too long. [201/160]
• ⚠️ - Line 158 - Line is too long. [203/160]
• ⚠️ - Line 166 - Line is too long. [240/160]
• ⚠️ - Line 169 - Don't use parentheses around a literal.
• ⚠️ - Line 169 - Line is too long. [236/160]

app/views/layouts/angular/_multi_tab_ansible_form_options.html.haml

• ⚠️ - Line 14 - Prefer to_s over string interpolation.
• ⚠️ - Line 21 - Prefer to_s over string interpolation.
• ⚠️ - Line 27 - Prefer to_s over string interpolation.

[gmcculloug]

Tested PR and looks good. Will need some followup PRs to limit resources but this is great progress and will help others get started with testing. Leave it to the UI team to determine when this is ready to merge.

[h-kataria]

@himdel @martinpovolny @dclarizio can you please merge, if it looks good to you guys.