Queue authentication check only for ems_cloud and ems_infra providers.

[jntullo]

The current check allows middleware provider checks to be directed to the queue, but at this time should be restricted to only cloud and infra providers.

@miq-bot add_label bug
cc: @agrare

[miq-bot]

Checked commit jntullo@a1bbc09 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

LGTM tested with a few infra providers (scvmm, vmware) and an openshift provider

[agrare]

@miq-bot add-label gaprindashvili/yes

[agrare]

cc @simaishi

[agrare]

@miq-bot assign @Fryguy

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 0d79c6d26a1b8522273e2b03db12d689d00de4a6
Author: Jason Frey <[email protected]>
Date:   Mon Nov 6 14:18:35 2017 -0500

    Merge pull request #2643 from jntullo/bug/only_queue_infra_cloud
    
    Queue authentication check only for ems_cloud and ems_infra providers.
    (cherry picked from commit 16d30e351f01dd378224690a625489477a5884bd)

[abonas]

is this fixing this bug? https://bugzilla.redhat.com/show_bug.cgi?id=1510038
cc @agrare @tumido @aljesusg

[tumido]

@abonas, yes. It's reverting Hawkular back to the old way of validating credentials. The PRs we're working on (ManageIQ/manageiq-providers-hawkular#100, #2577) are required, so we can join in displaying the new view in close future (?). This PR should unblock us on testing Hawkular for the release.

[aljesusg]

Yes @abonas now is working with this PR, and I validate with CA too. with correct error and sucess messages. We can close #2577.

[tumido]

@aljesusg, @abonas no, we shouldn't be closing these PRs (#2577, ManageIQ/manageiq-providers-hawkular#100), we're gonna need that code at some point.

[tumido]

@abonas, we (me adn @aljesusg) have PRs ready for the new dialog. Once they are merged we can be transitioned to the new dialog. Also, this change does not have to happen at the same moment, we're accepting both workflows.

PRs required for Hawkular to work with the new form:

• Add optional validate param to raw_connect manageiq-providers-hawkular#100
• Create cert_store if it's not created before validation manageiq-providers-hawkular#101
• Fix credential validation in Hawkular provider about number of arguments #2577