Fix skipping "first step" when saving a filter #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1511532 Fix appearing "Search Name is required" if user has not clicked on Save button yet, in Advanced search, when entering a name of a new filter. Practically, no step is skipped when saving a filter, just flash message is rendered in Adv search by default, when entering "save" mode. This was fixed by a simple condition. No flash message appears in the second step of saving a filter anymore, when user has not clicked on Save button yet.
|
@miq-bot add_label bug |
|
Checked commit hstastna@beb2a9b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2017
Fix skipping "first step" when saving a filter (cherry picked from commit 9c63c4d) https://bugzilla.redhat.com/show_bug.cgi?id=1513114
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1511532
Fix appearing "Search Name is required" if user has not clicked on Save
button yet, in Advanced search, when entering a name of a new filter.
Practically, no step is skipped when saving a filter, just flash message is
rendered in Adv search by default, when entering "save" mode. This was
fixed by a simple condition. No flash message appears in the second
step of saving a filter anymore, when user has not clicked on Save button
(for the second time) yet.
Before:
After:
