Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Cloud Provider C&U data collection #3069

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Re-enable Cloud Provider C&U data collection #3069

merged 1 commit into from
Dec 19, 2017

Conversation

bmclaughlin
Copy link
Contributor

Updated conditional checking for nil trees to allow 'Collect for all Clusters/Datastores' to be accessible for Cloud Provider CU collection.

@miq-bot add_labels bug, blocker, compute/cloud

https://bugzilla.redhat.com/show_bug.cgi?id=1525296

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commit bmclaughlin@2dc3a30 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/views/ops/_settings_cu_collection_tab.html.haml

  • ⚠️ - Line 38 - Line is too long. [273/160]

@bmclaughlin
Copy link
Contributor Author

Before:
1525296-before

After:
1525296-after

@h-kataria h-kataria self-assigned this Dec 19, 2017
@h-kataria h-kataria added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 19, 2017
@h-kataria h-kataria merged commit 6e32063 into ManageIQ:master Dec 19, 2017
@bmclaughlin bmclaughlin deleted the fetch-cu-data-on-cloud-providers branch December 19, 2017 20:45
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 4c31c3fe703b47e1694c2fb631ad6c073dcbffdd
Author: Harpreet Kataria <[email protected]>
Date:   Tue Dec 19 15:43:33 2017 -0500

    Merge pull request #3069 from bmclaughlin/fetch-cu-data-on-cloud-providers
    
    Re-enable Cloud Provider C&U data collection
    (cherry picked from commit 6e32063180c5efab6411c7ee61a01e35b1a1a3ad)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530762

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@h-kataria @simaishi
Merge pull request #3069 from bmclaughlin/fetch-cu-data-on-cloud-prov…
4c31c3f 
…iders

Re-enable Cloud Provider C&U data collection
(cherry picked from commit 6e32063)

https://bugzilla.redhat.com/show_bug.cgi?id=1530762
@bmclaughlin
Copy link
Contributor Author

@miq-bot add_labels fine/yes

simaishi pushed a commit that referenced this pull request Jan 10, 2018
@h-kataria @simaishi
Merge pull request #3069 from bmclaughlin/fetch-cu-data-on-cloud-prov…
c1b2eef 
…iders

Re-enable Cloud Provider C&U data collection
(cherry picked from commit 6e32063)

https://bugzilla.redhat.com/show_bug.cgi?id=1531554
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c1b2eef0be7a81b2c2aaea7b25454f7d24fc3ef6
Author: Harpreet Kataria <[email protected]>
Date:   Tue Dec 19 15:43:33 2017 -0500

    Merge pull request #3069 from bmclaughlin/fetch-cu-data-on-cloud-providers
    
    Re-enable Cloud Provider C&U data collection
    (cherry picked from commit 6e32063180c5efab6411c7ee61a01e35b1a1a3ad)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
blocker bug compute/cloud fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmclaughlin @miq-bot @simaishi @h-kataria @mzazrivec