Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project main page showtype #3184

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jan 7, 2018

Description

compute -> containers -> projects

Projects get a showtype=dashboard after visiting the dashboard view, this PR reset showtype=main, each time we return to main view.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1530610
Target: 5.9.1

Screeshots

Before:
peek 2018-01-07 17-31

After:
peek 2018-01-07 16-52

@yaacov
Copy link
Member Author

yaacov commented Jan 7, 2018

@miq-bot add_label bug, compute/containers, gaprindashvili/yes

@moolitayer @zeari @himdel please review

@miq-bot
Copy link
Member

miq-bot commented Jan 7, 2018

Checked commit yaacov@bd2e025 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018
@mzazrivec mzazrivec merged commit f39b9e8 into ManageIQ:master Jan 8, 2018
simaishi pushed a commit that referenced this pull request Jan 8, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 19ae1381bda9fbc064c905c26f030947e114e0f0
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jan 8 11:07:29 2018 +0100

    Merge pull request #3184 from yaacov/project-gtl-view-has-dashboard-mixin
    
    Fix project main page showtype
    (cherry picked from commit f39b9e84da84bfc1b35b5b30d19890a18b6f0af8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1532353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants