topologyService (js) - fix and test screen url to data url conversion #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipped tests for Network topology, since that one needs to be converted to the newer format first. Also skipped physical infrastructure detail screeen topology spec, since phinfra detail screen currently fails. |
|
Testing manually:
see if it works :) |
skateman
approved these changes
Jan 10, 2018
after the recent topology conversion (#3087) there were a few specail cases missed Accessing topology from infra & cloud summary screens was fixed in #3214. Access from container summary screen is fixed here. + tests for all the topology screens we can currently test Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533123
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/7bd7c734d9288417be2b9a5130b09096233d237e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 11, 2018
topologyService (js) - fix and test screen url to data url conversion (cherry picked from commit e2c0f81) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533519
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the recent topology conversion (#3087) there were a few special cases missed
Accessing topology from infra & cloud summary screens was fixed in #3214.
Access from container summary screen is fixed here.
+ tests for all the topology screens we can currently test
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533123
Cc @skateman, @Hyperkid123