Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added column 'status' to replication screen #3370

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Feb 2, 2018

related BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1540688

Issue described in BZ: replication screen throws error if replication on one of remote server was not set-up correctly.
After merging ManageIQ/pg-pglogical#20 corrupted subscription would be shown but without any indication that replication set-up is invalid

This PR adding column status to UI which would have value down in for not working subscriptions

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550119

BEFORE:
after

AFTER:
aftrer2

@miq-bot add-label replication, enhancement, gaprindashvili/yes

\cc @carbonin @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2018

@yrudman Cannot apply the following label because they are not recognized: replication

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2018

Checked commit yrudman@9700419 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.5-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this @yrudman

@mzazrivec mzazrivec self-assigned this Feb 5, 2018
@mzazrivec mzazrivec added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 5, 2018
@mzazrivec mzazrivec merged commit 661d893 into ManageIQ:master Feb 5, 2018
@yrudman yrudman deleted the added-status-column-to-replication-screen branch February 5, 2018 12:07
simaishi pushed a commit that referenced this pull request Mar 7, 2018
…ion-screen

Added column 'status' to replication screen
(cherry picked from commit 661d893)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552880
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit ca006bd631e6b0115669b552292204cb140c3215
Author: Milan Zázrivec <[email protected]>
Date:   Mon Feb 5 10:03:54 2018 +0100

    Merge pull request #3370 from yrudman/added-status-column-to-replication-screen
    
    Added column 'status' to replication screen
    (cherry picked from commit 661d893f569b4ea4f92e1daa0e6852d8043d3d04)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants