-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RBAC and Tagging Support to Ansible Credentials #3507
Add RBAC and Tagging Support to Ansible Credentials #3507
Conversation
@miq-bot add_label blocker |
@miq-bot add_label gaprindashvili/yes |
d57eac1
to
808ec76
Compare
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219 Add Policy toolbar button to enable tagging in Automation > Ansible > Credentials.
Add also tag_edit_form_field_changed for proper rendering of tagging screen.
4a2eaea
to
fd8b600
Compare
Add calling tag method to button method in ansible credential controller and also small refactoring of button method, for tagging support of Ansible Credentials.
Add displaying tags in the table in summary screen of a chosen credential, in Automation > Ansible > Credentials.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219 Add Policy toolbar button to enable tagging of any Ansible Credential from its summary page.
361d9eb
to
9586334
Compare
@h-kataria @dclarizio @martinpovolny Adding RBAC and Tagging Support to Ansible Credentials done so now I would need some review. Thanks so much! :) |
Checked commits hstastna/manageiq-ui-classic@2900b7e~...9586334 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
ManageIQ/manageiq#17079 is merged. |
looks good. |
…ntials_ui Add RBAC and Tagging Support to Ansible Credentials (cherry picked from commit f45a79b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553393
Gaprindashvili backport details:
|
@miq-bot add_label test |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219
Needs to merge with: ManageIQ/manageiq#17079
Done:
(Policy > Edit Tags)
tagging_edit
andtag_edit_form_field_changed
to routes to enable tagging for Ansible Credentials or for proper rendering of tagging screentag
method tobutton
method in ansible credential controller and also small refactoring ofbutton
method, in that controllerbutton
method in ansible credential controllerBefore:
After:
Note:
How to check RBAC support (one of possible scenarios):
remember those tags