Fix broken Automate icons

[epwinchell]

The following outdated "product" font family icons need to be replaced:

product-ae_instance => fa-file-text-o
product-ae_namespace => pficon-folder-close

Closes #349

[epwinchell]

@miq-bot add_label bug, euwe/no

[epwinchell]

@miq-bot add_label wip

[epwinchell]

@skateman As you found, we need to update the controllers in the following places:

https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/miq_ae_class_controller.rb#L359

https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/miq_ae_class_controller.rb#L363

https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/miq_ae_class/_instance_fields.html.haml#L25

[epwinchell]

@miq-bot assign @skateman

[himdel]

@epwinchell if you update the description to say Closes #349 (or fixes), it will auto-close when merged..

[epwinchell]

@miq-bot rm_label wip

[epwinchell]

@miq-bot assign @himdel

[skateman]

@miq-bot add_label wip
Do not merge as there is a PR against this PR, sorry @epwinchell, forgot to add this yesterday 😢

[himdel]

OK, waiting until @epwinchell merges that :)

[epwinchell]

@miq-bot rm_label wip

[himdel]

Test failure seems relevant..

  1) TreeNode::MiqAeMethod#icon returns with product product-method
     Failure/Error: expect(subject.icon).to eq(icon)
     
       expected: "product product-method"
            got: "product product-ae_method"
     
       (compared using ==)
     Shared Example Group: "TreeNode::Node#icon" called from ./spec/presenters/tree_node/miq_ae_method_spec.rb:8
     # ./spec/shared/presenters/tree_node/common.rb:20:in `block (3 levels) in <top (required)>'

(no idea which one is right, we seem to have both)

[miq-bot]

Checked commits https://github.com/epwinchell/manageiq-ui-classic/compare/8c57772b8da558c6c4ccfadfe576e5ffe342c616~...a6f494663389cc81b4eb02ad96657d938e448307 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
12 files checked, 0 offenses detected
Everything looks good. 🍰

[epwinchell]

@himdel All set

[epwinchell]

@miq-bot add_label graphics