Disable VNC Console for VMs hosted on ESXi 6.5 or greater #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label enhancement |
|
@skateman, please review. |
|
@bmclaughlin do we have a provider with 6.5 to test this? PM me please! |
|
Almost perfect, could you please squash the two commits? The tests should be together with the feature. Thanks! |
bmclaughlin
force-pushed
the
disable-vnc-button-for-vc65
branch
from
52692d4 to
a64c9be
Compare
|
@skateman, squashed. |
|
Checked commit bmclaughlin@a64c9be with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears per ManageIQ/manageiq#13798 VMware disabled VNC consoles in 6.5. Testing resulted in a "WebSocket connection to failed: Connection closed before receiving a handshake response".