Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Delete ems_storage #3572

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Mar 12, 2018

This reverts commit 8c8f1e6 (PR: #2988) as it was too much deleting.

Storage -> Block Storage -> Managers -> click on the Cinder Manager
Storage -> Object Storage -> Managers -> click on the Swift Manager

Before:
screen shot 2018-03-12 at 2 29 07 pm

After:
screen shot 2018-03-12 at 2 27 58 pm

@miq-bot add_label bug, gaprindashvili/no

@lpichler @mzazrivec please have a look.

This reverts commit 8c8f1e6.
@ZitaNemeckova ZitaNemeckova changed the title Revert "Delete ems_storage" Revert Delete ems_storage Mar 12, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commit ZitaNemeckova@b3f34c6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 10 offenses detected

app/helpers/application_helper/toolbar/ems_storage_center.rb

app/helpers/application_helper/toolbar/ems_storages_center.rb

@himdel
Copy link
Contributor

himdel commented Mar 12, 2018

Merging as this is blocking @lpichler from a blocker fix.

After that, this code should be removed again, but this time with all the 45 other ems_storage references that stayed in :).

@himdel himdel merged commit 77386e0 into ManageIQ:master Mar 12, 2018
@himdel himdel self-assigned this Mar 12, 2018
@himdel himdel added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 12, 2018
@ZitaNemeckova ZitaNemeckova deleted the return_of_the_ems_storage branch March 12, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants