Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dialog-user for info on valid inputs #3686

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Check dialog-user for info on valid inputs #3686

merged 3 commits into from
Apr 4, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Mar 27, 2018 •
edited
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558266

Automation -> Automate -> Customization -> Service Dialog -> create/edit one to have some regex limitation (like it must be number)
Service -> Catalog -> Catalog Item -> create/edit one catalog item to have service dialog from previous step
Service -> Catalog -> Service Catalog -> order one from previous step
Try to fill inputs incorrectly

Before:
screen shot 2018-03-27 at 2 41 08 pm
screen shot 2018-03-27 at 2 41 25 pm
After:
screen shot 2018-03-27 at 2 38 48 pm
screen shot 2018-03-27 at 2 37 54 pm
screen shot 2018-03-27 at 2 43 16 pm

@miq-bot add_label bug, gaprindashvili/yes, services

@mzazrivec mzazrivec self-assigned this Mar 28, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

Checked commits ZitaNemeckova/manageiq-ui-classic@7b536cd~...0ec8ebf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@ZitaNemeckova
Copy link
Contributor Author

@mzazrivec test failure fixed, please review. Thanks :)

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Apr 4, 2018
@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 4, 2018
@mzazrivec mzazrivec merged commit 391d76e into ManageIQ:master Apr 4, 2018
simaishi pushed a commit that referenced this pull request Apr 9, 2018
@mzazrivec @simaishi
Merge pull request #3686 from ZitaNemeckova/fix_validation_dialog_user
c416f8c 
Check dialog-user for info on valid inputs
(cherry picked from commit 391d76e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565148
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

Gaprindashvili backport details:

$ git log -1
commit c416f8c476403a06eae52e7fb5869b894966ea99
Author: Milan Zázrivec <[email protected]>
Date:   Wed Apr 4 10:07:15 2018 +0200

    Merge pull request #3686 from ZitaNemeckova/fix_validation_dialog_user
    
    Check dialog-user for info on valid inputs
    (cherry picked from commit 391d76e1cc8fb06c9eeb8dcfb8f6dea7b69ea67e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
blocker bug gaprindashvili/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZitaNemeckova @miq-bot @simaishi @mzazrivec