Fix Control explorer policies Search clear button #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
force-pushed
the
Control_explorer_policies_search_clear_button
branch
from
753ffb7 to
94f657b
Compare
hstastna
changed the title
hstastna
force-pushed
the
Control_explorer_policies_search_clear_button
branch
2 times, most recently
from
f774ff1 to
410f5be
Compare
hstastna
changed the title
|
@miq-bot remove_label wip |
skateman
suggested changes
Apr 17, 2018
| let(:tree) { :any_tree } | ||
|
|
||
| before do | ||
| allow(controller).to receive(:params).and_return(:action => 'adv_search_text_clear') |
There was a problem hiding this comment.
controller.instance_variable_set(:@_params, :action => 'adv_search_text_clear')
added 2 commits
April 17, 2018 12:30
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563316 Fix Search clear button when searching text under Control -> Explorer screens.
Add spec test to check the variable for Control -> Explorer screens, when clearing search text from the Search form by search clear button.
hstastna
force-pushed
the
Control_explorer_policies_search_clear_button
branch
from
410f5be to
880a385
Compare
|
@skateman test successfully updated. Thank you! ⭐ |
|
Checked commits hstastna/manageiq-ui-classic@4ec0391~...880a385 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Gaprindashvili? |
|
@miq-bot add_label gaprindashvili/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1563316
Fix Search clear button when searching text under Control -> Explorer screens.
Before searching text:
Before: (after clicking on clear search button, nothing has happened)
After: (after clicking on clear search button, the same as before searching text)
Details:
The problem was that after
adv_search_text_clearmethod (in application controller) was called,@search_textwas reset tonilBUT then set again to the previous value. This was happening the next way: inadv_search_text_clear,reloadmethod callstree_selectfrom miq policy controller, where because of callingget_node_infomethod@search_textwas set again, inset_search_textmethod here: https://github.com/ManageIQ/manageiq-ui-classic/compare/master...hstastna:Control_explorer_policies_search_clear_button?expand=1#diff-81673877a9cc40eb5089aa4a42bd3764R915The solution is to reset also
@sb[:pol_search_text][x_active_tree], not just@search_textor@sb[:search_text]as it is inadv_search_text_clearin app controller. This change is safe when changing accordions under Control -> Explorer: it keeps search text in@sb[:pol_search_text][x_active_tree]asx_active_treechanges, until search text is cleared for appropriate tree/accordion.