Add view selector to Block/Object Storage Managers #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2018 15:25
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558620 Add view selector to Block Storage Managers under Storage -> Block Storage -> Managers.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558620 Add view selector to Object Storage Managers under Storage -> Object Storage -> Managers.
|
@miq-bot add_label bug |
|
@miq-bot add_label gaprindashvili/yes |
|
Checked commits hstastna/manageiq-ui-classic@10c9b2d~...17586cf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
What I am missing in this PR is a simple spec to check that the toolbar is rendered on the relevant pages. It's pretty straightforward to add that. Example: https://github.com/ManageIQ/manageiq-ui-classic/pull/3857/files#diff-a32fdcf11645e7b22301a840fd2d6d7eR285 Can you add the tests in a follow-up PR, please? |
|
@martinpovolny Yes, of course, I was just waiting for this PR to be approoved as I was not 100% sure about this change. |
This was referenced May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1558620
Add missing view selector to Block and Object Storage Managers under Storage -> Block/Object Storage -> Managers.
Before:
Block Storage Managers, no View Selector:
Object Storage Managers, no View Selector:
After:
Block Storage Managers, Grid View:
Block Storage Managers, Tile View:
Block Storage Managers, List View:
Object Storage Managers, Grid View:
Object Storage Managers, Tile View:
Object Storage Managers, List View: