Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "full_center" layout #3970

Merged
merged 2 commits into from
May 22, 2018
Merged

Add a new "full_center" layout #3970

merged 2 commits into from
May 22, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented May 22, 2018

Add a new "full_center" layout - similar to center_div, but fully customizable - you just get the menus

the idea is for specific controllers to

    helper do
      def layout_full_center
        "layouts/my_custom_layout"
      end
    end

#3963: needed so that v2v doesn have extra margins around it

himdel added 2 commits May 22, 2018 12:39
used to determine which layout to use in layouts/_content
similar to center_div, but fully customizable - you just get the menus

the idea is for specific controllers to

    helper do
      def layout_full_center
        "layouts/my_custom/layout"
      end
    end
@himdel
Copy link
Contributor Author

himdel commented May 22, 2018

Cc @mzazrivec @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented May 22, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/184d0b5071665ff78b2f7c48f185e5e0eedc8744~...8476d59484820a8e3d1a785a36bf8d0af349ab5f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@martinpovolny martinpovolny merged commit 8d884ce into ManageIQ:master May 22, 2018
@martinpovolny martinpovolny self-assigned this May 22, 2018
@martinpovolny martinpovolny added this to the Sprint 87 Ending Jun 4, 2018 milestone May 22, 2018
@himdel himdel deleted the v2v-layout branch May 22, 2018 17:26
simaishi pushed a commit that referenced this pull request May 31, 2018
Add a new "full_center" layout
(cherry picked from commit 8d884ce)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 136e27aeefdda594ff629e63dab8dbf2d0c0e7ff
Author: Martin Povolny <[email protected]>
Date:   Tue May 22 19:23:00 2018 +0200

    Merge pull request #3970 from himdel/v2v-layout
    
    Add a new "full_center" layout
    (cherry picked from commit 8d884ce5c3f10635ce96eeb518b44e089063cc9e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants