Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display port group for VM instances #3992

Merged
merged 4 commits into from
May 30, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented May 24, 2018

Display port group for VM instances

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1561609

Steps for Testing/QA

screenshot from 2018-05-30 12-09-42
screenshot from 2018-05-30 12-09-27

@miq-bot miq-bot added the wip label May 24, 2018
@lgalis lgalis force-pushed the display_port_group_for_vm_instances branch 4 times, most recently from 74294b3 to 9af3e86 Compare May 28, 2018 03:59
@lgalis
Copy link
Contributor Author

lgalis commented May 29, 2018

@miq-bot add_label enhancement

@miq-bot
Copy link
Member

miq-bot commented May 29, 2018

@lgalis unrecognized command 'gaprindashvili', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@lgalis
Copy link
Contributor Author

lgalis commented May 29, 2018

@miq-bot add_label gaprindashvili/no

@lgalis lgalis force-pushed the display_port_group_for_vm_instances branch 2 times, most recently from e7676e0 to a19af8b Compare May 29, 2018 19:17
@lgalis lgalis force-pushed the display_port_group_for_vm_instances branch from a19af8b to db82f4e Compare May 29, 2018 19:48
@lgalis lgalis force-pushed the display_port_group_for_vm_instances branch from 6e98a82 to 957b870 Compare May 30, 2018 16:14
@miq-bot
Copy link
Member

miq-bot commented May 30, 2018

Checked commits lgalis/manageiq-ui-classic@5c583cc~...957b870 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@lgalis lgalis changed the title [WIP]Display port group for VM instances Display port group for VM instances May 30, 2018
@lgalis
Copy link
Contributor Author

lgalis commented May 30, 2018

@agrare, @h-kataria - please review

@miq-bot miq-bot removed the wip label May 30, 2018
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, tested with distributed portgroups and standard networks.

@h-kataria h-kataria self-assigned this May 30, 2018
@h-kataria h-kataria added this to the Sprint 87 Ending Jun 4, 2018 milestone May 30, 2018
@h-kataria h-kataria merged commit 5a89bb7 into ManageIQ:master May 30, 2018
@lgalis lgalis deleted the display_port_group_for_vm_instances branch May 31, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants