Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the fileicon in ConfiguredSystemDecorator #4038

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 4, 2018

The image_name for ConfiguredSystem always returns 'configured_system' and it's identical to the fonticon, so why not use it directly?

Parent issue: #4051

@epwinchell
Copy link
Contributor

@miq-bot add_reviewer @epwinchell

@miq-bot miq-bot requested a review from epwinchell June 4, 2018 16:54
@skateman skateman force-pushed the configured-system-img branch from 800a18e to 9949ae4 Compare June 4, 2018 16:55
@skateman skateman changed the title Specify the configured_system.png explicitly in its decorator Drop the fileicon in ConfiguredSystemDecorator Jun 4, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 4, 2018

Checked commit skateman@9949ae4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@epwinchell
Copy link
Contributor

@miq-bot add_label graphics, technical debt

@h-kataria h-kataria added this to the Sprint 87 Ending Jun 4, 2018 milestone Jun 4, 2018
@skateman
Copy link
Member Author

skateman commented Jun 5, 2018

@himdel @mzazrivec merge?

@mzazrivec mzazrivec assigned mzazrivec and unassigned h-kataria Jun 5, 2018
@mzazrivec mzazrivec modified the milestones: Sprint 87 Ending Jun 4, 2018, Sprint 88 Ending Jun 18, 2018 Jun 5, 2018
@mzazrivec mzazrivec merged commit e0ecc6e into ManageIQ:master Jun 5, 2018
@skateman skateman deleted the configured-system-img branch June 5, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants