Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use generic object definition fileicon if no picture present #4089

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 7, 2018

Unnecessary image, there's a fileicon, so ✂️ 🚽 🔥

Parent issue: #4051

@miq-bot add_label graphics, gaprindashvili/no
@miq-bot add_reviewer @epwinchell

@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2018

Checked commit skateman@b29bcc5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Jun 8, 2018
@mzazrivec mzazrivec added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 8, 2018
@mzazrivec mzazrivec merged commit 782c683 into ManageIQ:master Jun 8, 2018
@skateman skateman deleted the god-fileicon branch June 8, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants