Use the browser's native printing for asynchronously generated saved reports #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skateman Cannot apply the following label because they are not recognized: reporting |
skateman
force-pushed
the
pdf-saved-reports
branch
from
ce6e8ae to
9b25322
Compare
| @report = @result.report | ||
| @data = @result.get_generated_result(@sb[:render_type]) | ||
| # We need the last_run_on time from the original result | ||
| last_run_on = MiqReportResult.find(session[:report_result_id]).last_run_on |
There was a problem hiding this comment.
does this fetch the whole record and then take a single columnt or does it fetch just the single column from the db?
skateman
force-pushed
the
pdf-saved-reports
branch
from
9b25322 to
2da362c
Compare
|
Checked commits skateman/manageiq-ui-classic@e4f2ead~...2da362c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saved report PDFs are being generated asynchronously due to their size, the most time-consuming operation (except of the PDF generation itself) was the joining the sub-reports together. As we're moving the PDF generation to the client, I modified the asynchronous task to return with the
html_rowsonly. This is later being used in the rendering the print view using the@datainstance variable.To have a new window for printing, the
:popup => truewas not effective due to thewait_for_taskso I also had to add an exception for opening PDF reports in a new window. I know that the code is ugly, but it is now consistent with the other printing views in the UI. I will refactor this in the future in a separate PR.@miq-bot add_label pending core, gaprindashvili/no, reporting, enhancement
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @epwinchell
Depends on: ManageIQ/manageiq#17632
Closes: #4113
https://bugzilla.redhat.com/show_bug.cgi?id=1588072