Fix nonexistent pficon-error-octagon #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in https://www.patternfly.org/styles/icons/ pficon-error-octagon does not exist, and doesn't seem to have existed even in 3.3
…arning previously the background was an error background, and the icon doesn't exist fixed to match https://www.patternfly.org/styles/icons/
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/16ab7d4ff62a550aedddfe996e5f1eacf150037b~...13265011eaa2afed9a8bc95c95c1a8e308ffbf9d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion in #4224...
We have a bunch of places using
pficon-error-octagon. This does not exist in current patternfly, and doesn't seem to exist in 3.3 (ancient version) either.According to https://www.patternfly.org/styles/icons/, the right icon to use is
pficon-error-circle-o.So, using that error icon for the import error message.
But for Advanced settings in ops, the message is a warning, is called a warning in code, so it should not be using error styling.
Updated to use the proper warning style instead: