Make cascading auto-refresh behavior more consistent with how it was previously #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio Cannot apply the following label because they are not recognized: darga/yes euwe/yes |
|
@eclarizio @gmcculloug is an invalid assignee, ignoring... |
|
@miq-bot add_label darga/yes, euwe/yes |
|
Checked commit eclarizio@04bf1fb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@dclarizio Tested changes. Looks good. |
|
Backported to Euwe via ManageIQ/manageiq#13994 |
|
Backported to Darga via ManageIQ/manageiq#13993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces triggering of fields set to auto-refresh in order to stay consistent with the behavior prior to the cascading change.
The reasoning is that previously, if we had 1 field set to trigger and 4 set to listen, all 4 would get updated, but with the new cascading changes, the 4 set to listen would need to be set to also trigger. This fix will ensure that all 4 will update even if they are not set to trigger.
@miq-bot add_label darga/yes euwe/yes
@miq-bot assign @gmcculloug
@gmcculloug Please re-assign as necessary and/or tag people for review.