-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long_description field into Ansible Playbook catalog item form #4402
Conversation
@h-kataria Please, review :) |
@rvsia I think you got too many screenshots that look the same 😉. I'm not sure if this is backportable to fine because of Angular. Also you will need to work a little on the commit messages 😉 @miq-bot add_reviewer @epwinchell |
@skateman And two tabs looks ugly and I don't think it's good design in the old form. You have to click on "Display in Catalog" to show a tab and honestly, I couldn't find "long description" field when I started working on this bug. :D This solution makes more sense - you switch the option and you immediately see what you can change. I think it would be better to make a PR in the future and redesign both forms (old one and Angular) to look and work the same. There are more differences right now. This is just a BZ fix. In regarding of showing it in Catalog Items, long description is also missing in other items. And to maintain consistency a "Details" tab should be added to it, because we have "Basic Info" and "Details" tabs in Edit and in Catalog Item there is only a title "Basic Information". It deserves more attention by someone who designs these pages and stuff to make it properly and consinstence, but I don't know how it works here yet. :D |
%textarea{"ui-codemirror" => "{mode: 'htmlmixed', | ||
lineNumbers: true, | ||
angular: true, | ||
theme: 'eclipse', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you mention theme
explicitly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a leftover from testing, I'll remove it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked commits rvsia/manageiq-ui-classic@ad7c96c~...460e6d8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
https://bugzilla.redhat.com/show_bug.cgi?id=1482905
Description of problem:
Unable to add Long Description for Playbook based Catalog Items
Steps to Reproduce:
Before/After
Before
After
@miq-bot add_label gaprindashvili/yes, bug