Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run set_global_session_data() for csp_report() #4450

Conversation

mzazrivec
Copy link
Contributor

csp_report() is meant to report policy violation, it should not be touching session data at all (othewise it would cause ugly side-effects, such as deleting the whole session).

@martinpovolny review please?

csp_report() is meant to report policy violation, it should not be
touching session data at all (othewise it would cause ugly side-effects,
such as deleting the whole session).
@mzazrivec mzazrivec force-pushed the dont_run_set_global_session_data_for_csp_report branch from b100e38 to c893734 Compare August 10, 2018 13:20
@miq-bot
Copy link
Member

miq-bot commented Aug 10, 2018

Checked commits mzazrivec/manageiq-ui-classic@e9257c5~...c893734 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/controllers/application_controller.rb

spec/controllers/dashboard_controller_spec.rb

@martinpovolny martinpovolny self-assigned this Aug 10, 2018
@martinpovolny martinpovolny added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 10, 2018
@martinpovolny martinpovolny merged commit c56f634 into ManageIQ:master Aug 10, 2018
@mzazrivec mzazrivec deleted the dont_run_set_global_session_data_for_csp_report branch August 10, 2018 15:11
@h-kataria
Copy link
Contributor

Marked Gaprindashvili/yes to get this backported for https://bugzilla.redhat.com/show_bug.cgi?id=1626627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants