Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected flash message rendering after submitting VM reconfigure request #4722

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Corrected flash message rendering after submitting VM reconfigure request #4722

merged 1 commit into from
Oct 2, 2018

Conversation

romanblanco
Copy link
Member

Moved the partial rendering from angular components template

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1632782

Links

Steps for Testing/QA (from the BZ ticket)

  1. Have a infra provider (tested with RHV) and a VM on that provider.
  2. Go to VM's detail view, click Configuration -> Reconfigure this VM.
  3. Change something, e.g. VM's memory. Click Submit button.

@romanblanco
Corrected flash message rendering
095dfc1 
Removed the partial rendering from angular components template

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1632782
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commit romanblanco@095dfc1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Oct 2, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
@mzazrivec mzazrivec merged commit 8662911 into ManageIQ:master Oct 2, 2018
@romanblanco romanblanco deleted the bz1632782 branch October 2, 2018 13:28
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@mzazrivec @simaishi
Merge pull request #4722 from romanblanco/bz1632782
fa2620e 
Corrected flash message rendering after submitting VM reconfigure request

(cherry picked from commit 8662911)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632782
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit fa2620e2725dfc4d0751b64378d336f71d1b0632
Author: Milan Zázrivec <[email protected]>
Date:   Tue Oct 2 15:27:34 2018 +0200

    Merge pull request #4722 from romanblanco/bz1632782
    
    Corrected flash message rendering after submitting VM reconfigure request
    
    (cherry picked from commit 8662911211cf8a359dd61e9b2fed7d918b9b9ef3)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanblanco @miq-bot @simaishi @mzazrivec