Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed JS error, bottlenecks timeline does not have group levels. #4902

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fixed JS error, bottlenecks timeline does not have group levels. #4902

merged 1 commit into from
Nov 13, 2018

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Nov 9, 2018 •
edited
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648450

before:
before

after:
after

Issue introduced with changes in #4217
cc @CharlleDaniel

@h-kataria h-kataria requested a review from mzazrivec November 9, 2018 22:56
@h-kataria h-kataria force-pushed the bottlenecks_timeline_fix branch from 5e578c6 to 3acadea Compare November 9, 2018 23:10
@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2018

Checked commit h-kataria@3acadea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria h-kataria requested review from skateman and removed request for mzazrivec November 12, 2018 18:29
@martinpovolny martinpovolny added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 13, 2018
@martinpovolny martinpovolny merged commit 68e3d36 into ManageIQ:master Nov 13, 2018
simaishi pushed a commit that referenced this pull request Nov 13, 2018
@martinpovolny @simaishi
Merge pull request #4902 from h-kataria/bottlenecks_timeline_fix
52ea3bd 
Fixed JS error, bottlenecks timeline does not have group levels.

(cherry picked from commit 68e3d36)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648450
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 52ea3bdea34b7e579e936bdaa265b0fa945a288c
Author: Martin Povolny <[email protected]>
Date:   Tue Nov 13 07:57:39 2018 +0100

    Merge pull request #4902 from h-kataria/bottlenecks_timeline_fix
    
    Fixed JS error, bottlenecks timeline does not have group levels.
    
    (cherry picked from commit 68e3d3681a30271f203d1a4d73d1ab639f6cabd2)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1648450

@dclarizio dclarizio assigned martinpovolny and unassigned dclarizio Nov 13, 2018
@h-kataria h-kataria deleted the bottlenecks_timeline_fix branch April 9, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman Awaiting requested review from skateman

Assignees

@martinpovolny martinpovolny

Labels
bug hammer/backported timelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @miq-bot @simaishi @martinpovolny @dclarizio