Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to enable the download buttons on Utilization Report tab #4934

Conversation

h-kataria
Copy link
Contributor

Copy link
Contributor

@lgalis lgalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@h-kataria h-kataria force-pushed the download_button_fix_for_utilization_report branch from 5f347a8 to b359fc2 Compare November 16, 2018 17:40
@h-kataria h-kataria force-pushed the download_button_fix_for_utilization_report branch from b359fc2 to a98e694 Compare November 16, 2018 19:39
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2018

Checked commit h-kataria@a98e694 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio merged commit ced47cd into ManageIQ:master Nov 16, 2018
@dclarizio dclarizio added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 16, 2018
simaishi pushed a commit that referenced this pull request Nov 19, 2018
…zation_report

Fixed to enable the download buttons on Utilization Report tab

(cherry picked from commit ced47cd)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649945
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit a1cf2639f3d235703f3923e5170aa408f6d8d35e
Author: Dan Clarizio <[email protected]>
Date:   Fri Nov 16 12:43:15 2018 -0800

    Merge pull request #4934 from h-kataria/download_button_fix_for_utilization_report
    
    Fixed to enable the download buttons on Utilization Report tab
    
    (cherry picked from commit ced47cd800314a3fde82c30cce2012e01f33c7e1)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649945

@h-kataria h-kataria deleted the download_button_fix_for_utilization_report branch April 9, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants