CustomButtonSet - don't touch children/members directly, set button_order #5187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq#18368
The idea is, we shold not try to manipulate both
button_order
andmembers
for CustomButtons,members
should always followbutton_order
.The core PR adds an
after_save
toCustomButtonSet
that always updates the set of children to matchbutton_order
.This PR removes all code which updates members/children, and makes sure
button_order
gets updated instead.This probably needs some testing,
I'm not quite sure what..
(used twice)
was supposed to achieve,
find+save
sound like a no-op.